Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry metrics counter by ksm collector #4125

Merged
merged 3 commits into from
Jul 18, 2019

Conversation

clamoriniere
Copy link
Contributor

What does this PR do?

Add additional telemetry metrics to know how many metrics are return in the ksm prometheus payload.
the .telemetry.collector.metrics.count can have two tag keys:

  • name: the name of the collector, corresponding to the object type.
  • kube_namespace: the kubernetes namespace if the object is namespaced in kube.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@clamoriniere clamoriniere requested a review from a team July 16, 2019 12:51
@clamoriniere clamoriniere requested review from a team as code owners July 16, 2019 12:51
@clamoriniere clamoriniere changed the title [kubernetes_state] Add telemetry metrics counter by ksm collector [Add] [kubernetes_state] Add telemetry metrics counter by ksm collector Jul 16, 2019
@clamoriniere clamoriniere force-pushed the clamoriniere/ksm-telemetry branch from d740a29 to 30bf38f Compare July 16, 2019 13:12
@clamoriniere clamoriniere force-pushed the clamoriniere/ksm-telemetry branch from 30bf38f to c4fa295 Compare July 16, 2019 13:23
@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #4125 into master will decrease coverage by 2.01%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master    #4125      +/-   ##
==========================================
- Coverage   86.55%   84.54%   -2.02%     
==========================================
  Files         744       69     -675     
  Lines       38431     5415   -33016     
  Branches     4639      675    -3964     
==========================================
- Hits        33265     4578   -28687     
+ Misses       3922      683    -3239     
+ Partials     1244      154    -1090

@clamoriniere clamoriniere changed the title [Add] [kubernetes_state] Add telemetry metrics counter by ksm collector Add telemetry metrics counter by ksm collector Jul 16, 2019
Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments.

@clamoriniere clamoriniere force-pushed the clamoriniere/ksm-telemetry branch from a168c62 to d805c9c Compare July 16, 2019 15:42
@clamoriniere clamoriniere force-pushed the clamoriniere/ksm-telemetry branch from d805c9c to afd4622 Compare July 16, 2019 16:44
Co-Authored-By: Pierre Margueritte <[email protected]>
@clamoriniere
Copy link
Contributor Author

@pierre and @AlexandreYang: PR ready for a new review

Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mfpierre mfpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@clamoriniere clamoriniere merged commit d7a318f into master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants