-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry metrics counter by ksm collector #4125
Conversation
d740a29
to
30bf38f
Compare
Signed-off-by: cedric lamoriniere <[email protected]>
30bf38f
to
c4fa295
Compare
Codecov Report
@@ Coverage Diff @@
## master #4125 +/- ##
==========================================
- Coverage 86.55% 84.54% -2.02%
==========================================
Files 744 69 -675
Lines 38431 5415 -33016
Branches 4639 675 -3964
==========================================
- Hits 33265 4578 -28687
+ Misses 3922 683 -3239
+ Partials 1244 154 -1090 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments.
a168c62
to
d805c9c
Compare
kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py
Outdated
Show resolved
Hide resolved
Signed-off-by: cedric lamoriniere <[email protected]>
d805c9c
to
afd4622
Compare
kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py
Outdated
Show resolved
Hide resolved
kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py
Outdated
Show resolved
Hide resolved
Co-Authored-By: Pierre Margueritte <[email protected]>
@pierre and @AlexandreYang: PR ready for a new review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What does this PR do?
Add additional telemetry metrics to know how many metrics are return in the ksm prometheus payload.
the
.telemetry.collector.metrics.count
can have two tag keys:name
: the name of the collector, corresponding to the object type.kube_namespace
: the kubernetes namespace if the object is namespaced in kube.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached