Use the new RequestsWrapper for connecting to services #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4094 +/- ##
==========================================
- Coverage 86.55% 81.81% -4.75%
==========================================
Files 768 7 -761
Lines 41365 352 -41013
Branches 5009 76 -4933
==========================================
- Hits 35805 288 -35517
+ Misses 4193 27 -4166
+ Partials 1367 37 -1330 |
therve
requested changes
Jul 11, 2019
l0k0ms
reviewed
Jul 11, 2019
l0k0ms
reviewed
Jul 11, 2019
l0k0ms
reviewed
Jul 11, 2019
l0k0ms
reviewed
Jul 11, 2019
l0k0ms
reviewed
Jul 11, 2019
l0k0ms
reviewed
Jul 11, 2019
l0k0ms
reviewed
Jul 11, 2019
l0k0ms
reviewed
Jul 11, 2019
l0k0ms
reviewed
Jul 11, 2019
l0k0ms
reviewed
Jul 11, 2019
l0k0ms
reviewed
Jul 11, 2019
l0k0ms
reviewed
Jul 11, 2019
Co-Authored-By: Pierre Guceski <[email protected]>
AlexandreYang
approved these changes
Jul 11, 2019
therve
approved these changes
Jul 11, 2019
l0k0ms
approved these changes
Jul 11, 2019
|
@AlexandreYang should we fix it again? |
|
@AlexandreYang Yes unused |
|
Looks ok then. Thx for the confirmation.
@l0k0ms nothing more to fix, this PR is actually the fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Standardize configuration, esp. for proxy behavior