Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic cleanups #3706

Merged
merged 1 commit into from
May 3, 2019
Merged

Cosmetic cleanups #3706

merged 1 commit into from
May 3, 2019

Conversation

therve
Copy link
Contributor

@therve therve commented May 2, 2019

The patch does some small cleanups in the check, trying to improve debug
messages as well.

@therve therve requested a review from a team as a code owner May 2, 2019 09:05
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #3706 into master will increase coverage by 5.24%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master    #3706      +/-   ##
==========================================
+ Coverage   86.42%   91.66%   +5.24%     
==========================================
  Files         730        6     -724     
  Lines       37041      144   -36897     
  Branches     4360       22    -4338     
==========================================
- Hits        32012      132   -31880     
+ Misses       3855       10    -3845     
+ Partials     1174        2    -1172

Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me, but it warrants a changelog

@therve therve merged commit 37d6043 into master May 3, 2019
@therve therve deleted the therve/iis-nits branch May 3, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants