Adhere to code style #3526
Merged
Adhere to code style #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3526 +/- ##
==========================================
- Coverage 86.52% 81.86% -4.66%
==========================================
Files 726 4 -722
Lines 37524 353 -37171
Branches 4393 71 -4322
==========================================
- Hits 32466 289 -32177
+ Misses 3867 44 -3823
+ Partials 1191 20 -1171 |
gzussa
reviewed
Apr 17, 2019
| 'kube_daemonset_updated_number_scheduled': 'daemonset.updated', | ||
| 'kube_deployment_spec_paused': 'deployment.paused', | ||
| 'kube_deployment_spec_replicas': 'deployment.replicas_desired', | ||
| 'kube_deployment_spec_strategy_rollingupdate_max_unavailable': 'deployment.rollingupdate.max_unavailable', # noqa: E501 |
There was a problem hiding this comment.
Can't, it fails line length
gzussa
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Standardize code formatting across all integrations