-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iis] adds iis_host
tag to metrics
#3294
Conversation
will create tests but don't have ddev set up on windows so will rely on github for now |
Codecov Report
@@ Coverage Diff @@
## master #3294 +/- ##
=========================================
+ Coverage 85.44% 90% +4.55%
=========================================
Files 676 6 -670
Lines 35517 150 -35367
Branches 4205 25 -4180
=========================================
- Hits 30348 135 -30213
+ Misses 4016 12 -4004
+ Partials 1153 3 -1150 |
This reverts commit 9e82cd0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests! 💯
if `host` is not specified in yaml, the check connects to the local machine - behaves as if `host: "."`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks 👍
What does this PR do?
PR adds
iis_host
tags to the metrics.Motivation
If there are multiple instance configured, there's no distinction whether a metric came from which instance.
Additional Notes
iis_host
insteadReview checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached