Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iis] adds iis_host tag to metrics #3294

Merged
merged 10 commits into from
Mar 26, 2019
Merged

[iis] adds iis_host tag to metrics #3294

merged 10 commits into from
Mar 26, 2019

Conversation

ian28223
Copy link
Contributor

@ian28223 ian28223 commented Mar 12, 2019

What does this PR do?

PR adds iis_host tags to the metrics.

Motivation

If there are multiple instance configured, there's no distinction whether a metric came from which instance.

instances:
 - host: "."
 - host: "RemoteIISServer"
   username: "RemoteIISServer\user"
   password: "secret"

Additional Notes

  • If the host is either "." or "localhost", the agent's hostname will be used as the iis_host instead

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@ian28223
Copy link
Contributor Author

will create tests but don't have ddev set up on windows so will rely on github for now

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #3294 into master will increase coverage by 4.55%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #3294      +/-   ##
=========================================
+ Coverage   85.44%     90%   +4.55%     
=========================================
  Files         676       6     -670     
  Lines       35517     150   -35367     
  Branches     4205      25    -4180     
=========================================
- Hits        30348     135   -30213     
+ Misses       4016      12    -4004     
+ Partials     1153       3    -1150

This reverts commit 9e82cd0.
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests! 💯

iis/datadog_checks/iis/iis.py Outdated Show resolved Hide resolved
iis/datadog_checks/iis/iis.py Show resolved Hide resolved
if `host` is not specified in yaml, the check connects to the local machine - behaves as if `host: "."`
@ian28223 ian28223 requested a review from gzussa March 20, 2019 01:17
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 👍

@ian28223 ian28223 merged commit bec5478 into master Mar 26, 2019
@ian28223 ian28223 deleted the ianb/tag_iis_host branch March 26, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants