Upgrade aerospike dependency #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3235 +/- ##
==========================================
- Coverage 85.16% 75.96% -9.21%
==========================================
Files 683 60 -623
Lines 36133 4152 -31981
Branches 4120 496 -3624
==========================================
- Hits 30773 3154 -27619
+ Misses 4169 864 -3305
+ Partials 1191 134 -1057 |
|
LGTM ! Any reason why we didn't include this version directly when introducing the dependency ? |
|
Didn't want to change too much initially from how it was in -extras |
zippolyte
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes/features