Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect .hpa.condition gauges #3107

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Collect .hpa.condition gauges #3107

merged 2 commits into from
Feb 15, 2019

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Feb 13, 2019

What does this PR do?

Collect the kube_hpa_status_condition metric as kubernetes_state.hpa.condition.
Gauges are to sum by condition and status.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If PR adds a configuration option, it has been added to the configuration file.

Additional Notes

Anything else we should know when reviewing?

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #3107 into master will decrease coverage by 3.1%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3107      +/-   ##
==========================================
- Coverage   84.97%   81.86%   -3.11%     
==========================================
  Files         676        4     -672     
  Lines       34940      353   -34587     
  Branches     4188       68    -4120     
==========================================
- Hits        29689      289   -29400     
+ Misses       4032       44    -3988     
+ Partials     1219       20    -1199

Copy link
Member

@xlucas xlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@xvello xvello merged commit 3011114 into master Feb 15, 2019
@xvello xvello deleted the xvello/ksm_hpa_condition branch February 15, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants