Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3 #2999

Merged
merged 6 commits into from
Jan 23, 2019
Merged

Support Python 3 #2999

merged 6 commits into from
Jan 23, 2019

Conversation

nmuesch
Copy link
Collaborator

@nmuesch nmuesch commented Jan 22, 2019

What does this PR do?

This test already supported PY3. Mainly adds py3 testing to tox file, cleanup imports and pin checks_base, and cleans up the test folder.

Motivation

Test on 🐍 3️⃣ and cleanup.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If PR adds a configuration option, it has been added to the configuration file.

Additional Notes

Anything else we should know when reviewing?

@codecov-io
Copy link

Codecov Report

Merging #2999 into master will increase coverage by 3.99%.
The diff coverage is 90.9%.

@@            Coverage Diff             @@
##           master    #2999      +/-   ##
==========================================
+ Coverage   85.05%   89.05%   +3.99%     
==========================================
  Files         658        6     -652     
  Lines       35833      137   -35696     
  Branches     4243       24    -4219     
==========================================
- Hits        30478      122   -30356     
+ Misses       4113       12    -4101     
+ Partials     1242        3    -1239

@nmuesch nmuesch merged commit af38b5c into master Jan 23, 2019
@nmuesch nmuesch deleted the nick/iis3 branch January 23, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants