Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3 #2874

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Support Python 3 #2874

merged 1 commit into from
Jan 7, 2019

Conversation

gmmeyer
Copy link
Contributor

@gmmeyer gmmeyer commented Jan 4, 2019

What does this PR do?

Support Python 3 on Mesos Slave

Motivation

🐍 3️⃣ 🚂

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If PR adds a configuration option, it has been added to the configuration file.

Additional Notes

Anything else we should know when reviewing?

@codecov-io
Copy link

Codecov Report

Merging #2874 into master will decrease coverage by 20.31%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master    #2874       +/-   ##
===========================================
- Coverage   84.89%   64.58%   -20.32%     
===========================================
  Files         658        4      -654     
  Lines       37040      144    -36896     
  Branches     4396       32     -4364     
===========================================
- Hits        31445       93    -31352     
+ Misses       4314       38     -4276     
+ Partials     1281       13     -1268

Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 🤖 Sweet! Thanks

@gmmeyer gmmeyer merged commit f278d70 into master Jan 7, 2019
@gmmeyer gmmeyer deleted the greg/mesos_slave3 branch January 7, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants