Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3 #2837

Merged
merged 3 commits into from
Jan 17, 2019
Merged

Support Python 3 #2837

merged 3 commits into from
Jan 17, 2019

Conversation

nmuesch
Copy link
Collaborator

@nmuesch nmuesch commented Dec 27, 2018

What does this PR do?

Add Python3 support

Motivation

Getting ready for Py3

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If PR adds a configuration option, it has been added to the configuration file.

Additional Notes

Remove redundant aggregator fixture

@codecov-io
Copy link

codecov-io commented Dec 27, 2018

Codecov Report

Merging #2837 into master will decrease coverage by 0.73%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2837      +/-   ##
==========================================
- Coverage   84.71%   83.97%   -0.74%     
==========================================
  Files         667        4     -663     
  Lines       37912      287   -37625     
  Branches     4550       37    -4513     
==========================================
- Hits        32116      241   -31875     
+ Misses       4462       41    -4421     
+ Partials     1334        5    -1329

gmmeyer
gmmeyer previously approved these changes Dec 27, 2018
Copy link
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was very simple. Nice!

Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!

@nmuesch nmuesch merged commit be03437 into master Jan 17, 2019
@nmuesch nmuesch deleted the nick/ceph3 branch January 17, 2019 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants