Fix metric listings for activemq / activemq_xml #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zippolyte
requested changes
Oct 30, 2018
activemq/metadata.csv
Outdated
| activemq.queue.max_enqueue_time,gauge,10,millisecond,,The max the amount of time (ms) that messages remained enqueued.,0,activemq,max enq time | ||
| activemq.queue.min_enqueue_time,gauge,10,millisecond,,The min the amount of time (ms) that messages remained enqueued.,0,activemq,min enq time | ||
| activemq.queue.memory_pct,gauge,10,percent,,The percentage of memory currently in use,0,activemq,mem pct | ||
| activemq.queue.size,gauge,10,,,The amount of messages that remained queued.,0,activemq,enq size |
There was a problem hiding this comment.
can we add the message unit for this metric and the ones below please ?
activemq_xml/metadata.csv
Outdated
| activemq.broker.memory_pct,gauge,10,percent,,The percentage of memory in use.,0,activemq,mem pct | ||
| activemq.topic.count,gauge,,,,The number of topics.,0,activemq_xml,topic count | ||
| activemq.topic.consumer_count,gauge,10,,,The number of consumers.,0,activemq_xml,topic cnsmr count | ||
| activemq.topic.dequeue_count,gauge,10,,,The total number of messages sent to the queue since the last restart.,0,activemq_xml,topic deq count |
There was a problem hiding this comment.
Same here, we could addd the message unit to all the metrics related to number of message
|
@zippolyte - Just following up on this one. |
|
Sorry, lost track of it. |
|
Thanks @zippolyte! I've updated the activemq metadata file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix metric listings for activemq / activemq_xml
Motivation
Trello request
Review checklist
no-changeloglabel attached- [ ] Feature or bugfix has tests