[docker_daemon] detect bogus pids and dont traverse /proc for them. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SDK sibling for: DataDog/dd-agent#3205 + DataDog/dd-agent#3218 |
This was referenced Feb 24, 2017
hkaj
approved these changes
Mar 8, 2017
degemer
reviewed
Mar 9, 2017
docker_daemon/check.py
Outdated
| continue | ||
| self._report_net_metrics(container, tags) | ||
| except BogusPIDException: | ||
| self.log.exception('Unable to report cgroup metrics.') |
There was a problem hiding this comment.
Do we need log.exception? We know the stacktrace, we raise this error in only one place, unless I'm missing something?
Could we specify a bit the error message? Since we catch a BogusPIDException, couldn't we share more info than just a generic message with the user?
^ Feel free to disregard those messages, I obviously don't know the context. :)
There was a problem hiding this comment.
nah that's a good point: https://github.com/DataDog/dd-agent/pull/3205/files#r101987067
There was a problem hiding this comment.
I do agree there's no need to log the stack trace at all as this only happens here.
truthbk
force-pushed
the
jaime/dockerzeropid
branch
from
817a05c to
ae90a80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.