[KSM] Deprecate sending pod phase service checks #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfpierre
force-pushed
the
mfpierre/ksm-sc-deprecation
branch
from
b702f62 to
d941208
Compare
hkaj
requested changes
Aug 10, 2018
| # hostname_override: true | ||
| # | ||
| # Send (deprecated) pod.phase service checks (default true, will be turned off in future versions) | ||
| # We recommend using the gauges instead, which will benefit from history |
There was a problem hiding this comment.
the corresponding gauges, maybe also add their name or at least one of them.
There was a problem hiding this comment.
which will benefit from historical data unlike service checks
| # | ||
| # Send (deprecated) pod.phase service checks (default true, will be turned off in future versions) | ||
| # We recommend using the gauges instead, which will benefit from history | ||
| # send_pod_phase_service_checks: false |
mfpierre
force-pushed
the
mfpierre/ksm-sc-deprecation
branch
from
d941208 to
d6ccf35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deprecate sending pod phase service checks, add an option to disable sending them.
An integration warning will be sent if the option is enabled.
Motivation
Deprecate and eventually remove these service checks, the respective gauges should be used.
Review checklist
no-changeloglabel attached