Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump confluent-kafka to 2.6.1 to address CVE #19099

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

Kyle-Neale
Copy link
Contributor

@Kyle-Neale Kyle-Neale commented Nov 20, 2024

What does this PR do?

https://datadoghq.atlassian.net/browse/AI-4128

This updates confluent-kafka builders and dependency to address this CVE

https://github.com/confluentinc/librdkafka/releases/tag/v2.6.1

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.30%. Comparing base (74231f6) to head (4639a28).
Report is 11 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
kafka_consumer 93.58% <ø> (+39.27%) ⬆️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@Kyle-Neale Kyle-Neale marked this pull request as ready for review November 20, 2024 22:46
@Kyle-Neale Kyle-Neale requested review from a team as code owners November 20, 2024 22:46
@@ -70,6 +70,8 @@ exclude = true
aerospike = ['Apache-2.0']
# https://github.com/pyca/cryptography/blob/main/LICENSE
cryptography = ['Apache-2.0', 'BSD-3-Clause', 'PSF']
# https://github.com/confluentinc/confluent-kafka-python/blob/master/LICENSE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a TODO here to remove it after it's fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kyle-Neale Kyle-Neale merged commit 1435476 into master Nov 21, 2024
46 of 48 checks passed
@Kyle-Neale Kyle-Neale deleted the kyle.neale/update-confluent-kafka branch November 21, 2024 13:07
datadog-agent-integrations-bot bot pushed a commit that referenced this pull request Nov 22, 2024
* Bump confluent-kafka to 2.6.1 to address CVE

* Add changelog

* Override confluent-kafka license (#19100)

(cherry picked from commit 1435476)
HadhemiDD pushed a commit that referenced this pull request Nov 25, 2024
* Bump confluent-kafka to 2.6.1 to address CVE

* Add changelog

* Override confluent-kafka license (#19100)

(cherry picked from commit 1435476)

Co-authored-by: Kyle Neale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants