Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mongo] allow customizable collection interval for collection and sharded data distribution metrics #19098

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

lu-zhengda
Copy link
Contributor

@lu-zhengda lu-zhengda commented Nov 20, 2024

What does this PR do?

This PR introduces a new configuration option, metrics_collection_interval, which allows users to customize the collection interval for collection statistics, index statistics, and sharded data distribution metrics.

Motivation

The $collStats, $indexStats, and $shardedDataDistribution aggregation pipelines can be resource-intensive for large databases. Allowing users to adjust the collection frequency provides flexibility to minimize the integration's performance impact while still gathering important metrics.

https://datadoghq.atlassian.net/browse/DBMON-4786

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.03%. Comparing base (7b18212) to head (8f66b8f).
Report is 14 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mongo 93.13% <100.00%> (-0.46%) ⬇️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

nenadnoveljic
nenadnoveljic previously approved these changes Nov 21, 2024
@lu-zhengda lu-zhengda added this pull request to the merge queue Nov 21, 2024
Merged via the queue into master with commit 52aeb78 Nov 21, 2024
35 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/shard branch November 21, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants