Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax MEMORY_USAGE_THRESHOLD in test to account for slightly increased mem from tracing #18890

Merged
merged 3 commits into from
Oct 23, 2024
Merged

relax MEMORY_USAGE_THRESHOLD in test to account for slightly increased mem from tracing #18890

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ced3aaa
reset peak before trace mem
lu-zhengda Oct 22, 2024
ebd1d7d
increase test mem threshold to account for additional mem from trace
lu-zhengda Oct 22, 2024
efcd422
add comments
lu-zhengda Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion datadog_checks_base/tests/base/utils/db/test_db_statements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,8 @@ def test_compute_derivative_rows_mem_usage(self):
Make sure we minimize the temporary objects created when computing the derivative
This test is skipped if tracemalloc is not available
'''
MEMORY_USAGE_THRESHOLD = 7 * 1024 * 1024 # 7 MB
# The memory usage threshold takes tracing overhead into account
MEMORY_USAGE_THRESHOLD = 8 * 1024 * 1024 # 8 MB

try:
import tracemalloc
Expand Down
Loading