Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqlserver] Refactor sqlserver database metrics #18883

Merged
merged 28 commits into from
Oct 22, 2024

Conversation

lu-zhengda
Copy link
Contributor

@lu-zhengda lu-zhengda commented Oct 21, 2024

What does this PR do?

This PR migrates following dynamic metrics to database_metrics for better maintainability and testability.

  • SQLServer AlwaysOn metrics
  • SQLServer FCI metrics
  • SQLServer file stats metrics
  • SQLServer primary log shipping metrics
  • SQLServer secondary log shipping metrics
  • SQLServer server state metrics
  • SQLServer tempdb file space usage metrics
  • SQLServer index usage metrics
  • SQLServer database index fragmentation metrics (increase default collection interval to 5 mins)
  • SQLServer os tasks metrics
  • SQLServer master files metrics
  • SQLServer database files metrics
  • SQLServer database stats metrics
  • SQLServer database backup metrics (increase default collection interval to 5 mins)
  • SQLServer os schedulers metrics
  • SQLServer database replication stats metrics
  • SQLServer availability replicas metrics
  • SQLServer availability groups metrics

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 97.45989% with 19 lines in your changes missing coverage. Please review.

Project coverage is 88.58%. Comparing base (6cd3ac6) to head (5c1e9d5).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sqlserver 91.14% <97.45%> (+11.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lu-zhengda lu-zhengda changed the title Zhengda.lu/sqlserver database metrics refactor [sqlserver] Refactor sqlserver database metrics Oct 21, 2024
@lu-zhengda lu-zhengda marked this pull request as ready for review October 22, 2024 16:03
@lu-zhengda lu-zhengda requested review from a team as code owners October 22, 2024 16:03
@lu-zhengda lu-zhengda added this pull request to the merge queue Oct 22, 2024
Merged via the queue into master with commit b84e4d8 Oct 22, 2024
48 of 49 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/sqlserver-database-metrics-refactor branch October 22, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants