[mongo] Apply configured timeout to timeoutMS connection option #18843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-zhengda
added
backport/7.59.x
and removed
ecosystems/review-requested
product/review-requested
agent/review-requested
labels
nenadnoveljic
approved these changes
Oct 16, 2024
datadog-agent-integrations-bot bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
(cherry picked from commit c16dcc6)
4 tasks
HadhemiDD
pushed a commit
that referenced
this pull request
Oct 16, 2024
…) (#18847) (cherry picked from commit c16dcc6) Co-authored-by: Zhengda Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR applies the
timeoutconfig option (defaults to 30s) totimeoutMSconnection option. WithtimeoutMS, a client-side operation timeout is properly specified. Prior to the change, long running integration command will get a network timeout due tosocketTimeoutMS, however the operation will still be running on the server side. By settingtimeoutMS, it ensures the operation is properly ended when exceeds defined timeout.Motivation
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged