Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect binlog permissions errors #18785

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

sethsamuel
Copy link
Contributor

@sethsamuel sethsamuel commented Oct 7, 2024

What does this PR do?

Checks if binary logs are enabled before logging a warning about permissions.

Motivation

If binlogs are disabled the SHOW will fail but it's not a permissions error, binlogs are just disabled.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.93%. Comparing base (3fa5466) to head (309c5a1).
Report is 8 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
mysql 88.62% <0.00%> (-0.92%) ⬇️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@sethsamuel sethsamuel merged commit efa33ba into master Oct 8, 2024
64 of 69 checks passed
@sethsamuel sethsamuel deleted the seth.samuel/DBMON-4639-bin-logs branch October 8, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants