Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mongo] always emit database_instance #18750

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

lu-zhengda
Copy link
Contributor

What does this PR do?

Always emit database_instance metadata regardless of dbm status.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.06%. Comparing base (c1e8530) to head (f8eedc2).
Report is 6 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mongo 93.26% <100.00%> (-0.26%) ⬇️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@lu-zhengda lu-zhengda merged commit af47a3d into master Oct 1, 2024
41 of 43 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/mongo-db branch October 1, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants