Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy: add support for tls_inspector metrics #18536

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

wdauchy
Copy link
Contributor

@wdauchy wdauchy commented Sep 9, 2024

What does this PR do?

add support for tls_inspector metrics

see also
https://www.envoyproxy.io/docs/envoy/latest/configuration/listeners/listener_filters/tls_inspector

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@wdauchy wdauchy force-pushed the william.dauchy/0 branch 2 times, most recently from dffaee5 to 7193d37 Compare September 9, 2024 17:41
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (2d82a48) to head (79f645f).
Report is 12 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
envoy 95.09% <100.00%> (+5.58%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@wdauchy wdauchy force-pushed the william.dauchy/0 branch 7 times, most recently from 37f7159 to f8ba4ac Compare September 9, 2024 19:29
@wdauchy wdauchy marked this pull request as ready for review September 9, 2024 19:36
@wdauchy wdauchy requested a review from a team as a code owner September 9, 2024 19:36
@steveny91 steveny91 merged commit f768b9e into master Sep 9, 2024
40 of 41 checks passed
@steveny91 steveny91 deleted the william.dauchy/0 branch September 9, 2024 20:13
steveny91 added a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants