Submit k_state.nodes.by_condition as gauge instead of counter #1840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Because
AgentCheck.count()
will submit the resulting count as acounter
instead of agauge
, this PR moves to an internal use of acollections.Counter()
, to submit node counts asgauge
.Motivation
Ensure the metric type is correct. Upgrading all agents will be necessary for the correct type to be consistently picked up.
Review checklist
no-changelog
label attached- [ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repoAdditional Notes
Anything else we should know when reviewing?