Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata table #17875

Conversation

sethsamuel
Copy link
Contributor

@sethsamuel sethsamuel commented Jun 17, 2024

What does this PR do?

Update the table queried for metadata for MySQL 5.6.

Motivation

performance_schema table wasn't introduced until 5.7.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (6c65084) to head (a431ba9).

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mysql 83.05% <100.00%> (-0.03%) ⬇️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@@ -0,0 +1 @@
Fix MySQL integration metadata table source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we specify the mysql version relates to this fix?

@sethsamuel sethsamuel requested a review from lu-zhengda June 20, 2024 12:59
@sethsamuel sethsamuel merged commit 7832d0b into master Jun 20, 2024
40 checks passed
@sethsamuel sethsamuel deleted the seth.samuel/DBMON-4200-Table-performance_schema.global_variables-doesn-t-exist branch June 20, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants