Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PyMySQL #17696

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Upgrade PyMySQL #17696

merged 2 commits into from
Jun 3, 2024

Conversation

JulesDT
Copy link
Member

@JulesDT JulesDT commented May 31, 2024

What does this PR do?

This PR upgrades PyMySQL to the newest version to fix a bug in the library

Motivation

This changelog

Additional Notes

  • Fixes DataDog/image-vuln-scans#1489

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@JulesDT JulesDT requested a review from a team as a code owner May 31, 2024 19:24
@datadog-agent-integrations-bot datadog-agent-integrations-bot bot added documentation qa/skip-qa Automatically skip this PR for the next QA team/documentation labels May 31, 2024
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@JulesDT JulesDT force-pushed the julesdt/upgrade-pymysql branch from 3da7d54 to 2d62381 Compare May 31, 2024 19:29
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for docs

@L3n41c
Copy link
Member

L3n41c commented Jun 1, 2024

Given the severity of the fixed vuln, this should probably be backported to 7.55.x.

@vivek-datadog vivek-datadog merged commit 9f6427b into master Jun 3, 2024
64 of 65 checks passed
@vivek-datadog vivek-datadog deleted the julesdt/upgrade-pymysql branch June 3, 2024 13:46
datadog-agent-integrations-bot bot pushed a commit that referenced this pull request Jun 3, 2024
(cherry picked from commit 9f6427b)
steveny91 pushed a commit that referenced this pull request Jun 3, 2024
(cherry picked from commit 9f6427b)

Co-authored-by: JulesD <[email protected]>
datadog-agent-integrations-bot bot pushed a commit that referenced this pull request Jun 4, 2024
(cherry picked from commit 9f6427b)
Kyle-Neale pushed a commit that referenced this pull request Jun 4, 2024
(cherry picked from commit 9f6427b)

Co-authored-by: JulesD <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants