[DBMON-3642] Proper handle events_statements_* timer_end overflow #16936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Test Results 16 files 16 suites 15m 38s ⏱️ Results for commit a5f2426. |
nenadnoveljic
approved these changes
Feb 23, 2024
3 tasks
FlorentClarret
pushed a commit
that referenced
this pull request
Mar 1, 2024
…6936) * proper handle timer_end overflow * add changelog * fix typo
NouemanKHAL
pushed a commit
that referenced
this pull request
Mar 4, 2024
…6936) * proper handle timer_end overflow * add changelog * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR handles the case when events_statements_*
timer_endoverflows.timer_endis in picosecond has column typeBIGINT, when it overflows and wrapped around, the calculated of statement timestamp based on serverUPTIMEcould become stale.This PR handles this case by calculate "how many time timer_end overflowed" and makes up the difference.
Motivation
MySQL explain plan events are dropped when timestamp is stale. This change ensures we don't get a stake timestamp.
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.