Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBMON-3686] Exclude events_statements_cpu when checking enabled events_statements consumers #16924

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

lu-zhengda
Copy link
Contributor

@lu-zhengda lu-zhengda commented Feb 21, 2024

What does this PR do?

This PR excludes events_statements_cpu (introduced in MySQL 8.0.28) when checking enabled events_statements consumers. MySQL statement sampling collects from events_statements_history_long, events_statements_history or events_statements_current.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e877633) 90.50% compared to head (172d4e2) 90.62%.
Report is 3 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
mysql 87.46% <100.00%> (-0.04%) ⬇️
presto ?
solr ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

Test Results

   16 files     16 suites   15m 18s ⏱️
  139 tests   139 ✅ 0 💤 0 ❌
1 112 runs  1 103 ✅ 9 💤 0 ❌

Results for commit 172d4e2.

@lu-zhengda lu-zhengda merged commit d53ff02 into master Feb 22, 2024
46 of 48 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/mysql-events-statement branch February 22, 2024 12:10
NouemanKHAL pushed a commit that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants