Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBMON-3271] DBM integrations now defaulted to use new go-sqllexer pkg to obfuscate sql statements #16681

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

lu-zhengda
Copy link
Contributor

What does this PR do?

This PR defaults postgres, mysql and sqlserver integrations' obfuscation_mode to obfuscate_and_normalize. With this change, the integration will use go-sqllexer as the default sql statements obfuscator.

Motivation

Default to go-sqllexer as the default sql statements obfuscator to better obfuscation on edge cases and error handling.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (edd4821) 90.55% compared to head (c63f7e3) 90.64%.
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mysql 87.46% <ø> (-0.07%) ⬇️
postgres 92.81% <ø> (-0.04%) ⬇️
presto ?
solr ?
sqlserver 89.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

Test Results

   48 files     48 suites   1h 17m 55s ⏱️
  691 tests   677 ✅  14 💤 0 ❌
6 126 runs  5 784 ✅ 342 💤 0 ❌

Results for commit c63f7e3.

@lu-zhengda lu-zhengda merged commit 40c2f3f into master Jan 23, 2024
44 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/default-obfuscator branch January 23, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants