Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listener and cluster SSL metrics to OpenMetrics version of check #16649

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

steveny91
Copy link
Contributor

What does this PR do?

Add a few more metrics for the OMv2 version of integration.

Motivation

Feature request.

@ghost ghost added the integration/envoy label Jan 18, 2024
Copy link

github-actions bot commented Jan 18, 2024

Test Results

  6 files    6 suites   2m 18s ⏱️
 93 tests  91 ✅  2 💤 0 ❌
282 runs  255 ✅ 27 💤 0 ❌

Results for commit 897d131.

♻️ This comment has been updated with latest results.

@steveny91 steveny91 marked this pull request as ready for review January 18, 2024 01:26
@steveny91 steveny91 requested a review from a team as a code owner January 18, 2024 01:26
@steveny91 steveny91 changed the title add additional metrics Add listener and cluster SSL metrics to OpenMetrics version of check Jan 18, 2024
@steveny91 steveny91 requested a review from a team January 18, 2024 01:27
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e752727) 90.45% compared to head (897d131) 90.55%.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
envoy 95.07% <100.00%> (+0.15%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nathanmadams nathanmadams added the assets/no-deploy Prevents APW from deploying this PR in staging label Jan 30, 2024
@steveny91 steveny91 merged commit 756bf28 into master Feb 1, 2024
32 checks passed
@steveny91 steveny91 deleted the sy/envoy-listener-metrics branch February 1, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants