Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint tag to legacy #16478

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Add endpoint tag to legacy #16478

merged 5 commits into from
Dec 21, 2023

Conversation

steveny91
Copy link
Contributor

What does this PR do?

Add the a endpoint tag to the legacy version of the envoy check.

Motivation:

While going over the check, I notice that the OpenMetricsV2 implementation has a useful endpoint check. The legacy version however lacks this check. This can cause problems if a single agent were to monitor different stats_url endpoints. There might be no way to distinguish them from one another.

  envoy.server.state                                         gauge  1703021786  0                                                                  
  envoy.server.total_connections                             gauge  1703021786  0                                                                  
  envoy.server.uptime                                        gauge  1703021786  160                                                                
  envoy.server.version                                       gauge  1703021786  10011081    

to this:

envoy.server.state                                         gauge  1703087799  0                     endpoint:http://localhost:8001/stats         
envoy.server.total_connections                             gauge  1703087799  0                     endpoint:http://localhost:8001/stats         
envoy.server.uptime                                        gauge  1703087799  350                   endpoint:http://localhost:8001/stats         
envoy.server.version                                       gauge  1703087799  10011081              endpoint:http://localhost:8001/stats 

Additional changes:
Added papertrail comment in regards to one of the tests.

@ghost ghost added the integration/envoy label Dec 20, 2023
@steveny91 steveny91 marked this pull request as ready for review December 20, 2023 19:23
@steveny91 steveny91 requested a review from a team as a code owner December 20, 2023 19:23
Copy link

github-actions bot commented Dec 20, 2023

Test Results

    6 files      6 suites   2m 20s ⏱️
  92 tests   90 ✔️   2 💤 0
279 runs  253 ✔️ 26 💤 0

Results for commit f346608.

♻️ This comment has been updated with latest results.

FlorentClarret
FlorentClarret previously approved these changes Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb6538b) 90.53% compared to head (f346608) 90.63%.
Report is 8 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
envoy 95.01% <100.00%> (+0.30%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@Kyle-Neale Kyle-Neale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steveny91 steveny91 merged commit 1bf6702 into master Dec 21, 2023
37 checks passed
@steveny91 steveny91 deleted the sy/envoy-legacy-endpoint branch December 21, 2023 20:34
github-actions bot pushed a commit to chhetripradeep/integrations-core that referenced this pull request Dec 25, 2023
* add endpoint tag to legacy

* changelog

* grammar nit

* lint

* lint 1bf6702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants