Fix error while fetching mysql pid from psutil #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmmeyer
previously approved these changes
May 29, 2018
nmuesch
reviewed
May 29, 2018
| except Exception: | ||
| self.log.exception("Error while fetching mysql pid from psutil") | ||
| except (psutil.AccessDenied, psutil.ZombieProcess, psutil.NoSuchProcess): | ||
| continue |
There was a problem hiding this comment.
Can we debug log the exception here to help if we run into issues?
There was a problem hiding this comment.
Not sure it'd help, if the codepath gets there it means a process died during the iteration. If that process was exactly mysql, the pid would be None anyways so in terms of responsibilities of the function we're good. If that wasn't mysql, we don't care at all.
gmmeyer
approved these changes
May 30, 2018
| time.sleep(2) | ||
|
|
||
| return connected | ||
| MYSQL_FLAVOR = os.getenv('MYSQL_FLAVOR', 'mysql') |
There was a problem hiding this comment.
Why not have the version here too?
There was a problem hiding this comment.
It's used only once so I thought it didn't deserve to be a module-global
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the logic we use to see if the server is running, currently broken as in #1325
Motivation
#1325, thanks @steffenweber for reporting
Review checklist
no-changeloglabel attachedAdditional Notes
A test was added to check fix behaviour and prevent regressions