Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for harbor < 1.10 #15634

Merged
merged 5 commits into from
Aug 28, 2023

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented Aug 21, 2023

What does this PR do?

Removes support for harbor versions <= 1.8.

Motivation

#12595 removed the test environment for version 1.8, since harbour's documentation no longer refers to it. While looking into an issue for this integration, I saw an opportunity to clean up by dropping code that's only there to support older versions.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@alopezz alopezz requested review from a team as code owners August 21, 2023 13:35
@alopezz alopezz force-pushed the alopez/harbor/remove-code-for-old-versions branch from 5197227 to 87f0ce2 Compare August 21, 2023 13:37
@github-actions
Copy link

Test Results

  8 files    8 suites   2m 13s ⏱️
11 tests 11 ✔️ 0 💤 0
48 runs  44 ✔️ 4 💤 0

Results for commit 87f0ce2.

Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alopezz alopezz merged commit 75081d7 into master Aug 28, 2023
@alopezz alopezz deleted the alopez/harbor/remove-code-for-old-versions branch August 28, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants