Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config model docs #15608

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Update config model docs #15608

merged 3 commits into from
Aug 17, 2023

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Aug 17, 2023

Motivation

#15212

@ofek ofek requested review from a team as code owners August 17, 2023 18:12
@jhgilbert jhgilbert self-assigned this Aug 17, 2023
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback for consistency with our style guide!

docs/developer/meta/config-models.md Outdated Show resolved Hide resolved
docs/developer/meta/config-models.md Outdated Show resolved Hide resolved
docs/developer/meta/config-models.md Show resolved Hide resolved
docs/developer/meta/config-models.md Outdated Show resolved Hide resolved
docs/developer/meta/config-models.md Show resolved Hide resolved
docs/developer/meta/config-models.md Show resolved Hide resolved
docs/developer/meta/config-models.md Show resolved Hide resolved
docs/developer/meta/config-models.md Outdated Show resolved Hide resolved
docs/developer/meta/config-models.md Outdated Show resolved Hide resolved
@jhgilbert jhgilbert removed their assignment Aug 17, 2023
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ofek ofek merged commit 28023eb into master Aug 17, 2023
@ofek ofek deleted the ofek/pydantic branch August 17, 2023 19:06
github-actions bot pushed a commit that referenced this pull request Aug 17, 2023
* Update config model docs

* Apply suggestions from code review

Co-authored-by: Rosa Trieu <[email protected]>

* Apply suggestions from code review

Co-authored-by: Rosa Trieu <[email protected]>

---------

Co-authored-by: Rosa Trieu <[email protected]> 28023eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants