Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update datadog-checks-base dependency version to 32.6.0 #15604

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Update datadog-checks-base dependency version to 32.6.0 #15604

merged 6 commits into from
Aug 18, 2023

Conversation

vivek-datadog
Copy link
Contributor

@vivek-datadog vivek-datadog commented Aug 17, 2023 •
edited
Loading

What does this PR do?

Motivation

Update datadog-checks-base to 32.6.0 for integrations that use config models

Follow-up PR for #15427

Without this version bump Python 3 config validation would no longer work and there would be errors in the logs

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@vivek-datadog vivek-datadog added changelog/Fixed qa/skip-qa Automatically skip this PR for the next QA labels Aug 17, 2023
@vivek-datadog vivek-datadog requested review from a team as code owners August 17, 2023 14:55
iliakur
iliakur reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lost track at this point, is this part of the pydantic v2 upgrade follow-ups? or is this a follow-up to the pre-release dep upgrade?

Could you link the relevant predecessor pr in the motivation?

@codecov
Copy link

codecov bot commented Aug 17, 2023 •
edited
Loading

Codecov Report

Merging #15604 (3ea9cff) into master (f6a46e2) will decrease coverage by 0.07%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Flag Coverage Δ
ambari 85.75% <ø> (ø)
apache 95.08% <ø> (ø)
cassandra_nodetool 93.16% <ø> (ø)
ceph 91.07% <ø> (ø)
cisco_aci 95.27% <ø> (ø)
consul 91.65% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_cluster_agent 90.19% <ø> (ø)
druid 98.47% <ø> (ø)
foundationdb 78.50% <ø> (ø)
glusterfs 80.09% <ø> (+0.92%) ⬆️
go_expvar 92.73% <ø> (ø)
harbor 80.04% <ø> (ø)
kube_dns 95.97% <ø> (ø)
kube_metrics_server 94.87% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kube_scheduler 96.53% <ø> (ø)
kubelet 91.03% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linux_proc_extras 96.22% <ø> (ø)
mapr 82.70% <ø> (ø)
marathon 83.43% <ø> (ø)
mesos_master 89.75% <ø> (ø)
mesos_slave 93.63% <ø> (ø)
nagios 89.01% <ø> (ø)
nfsstat 95.20% <ø> (ø)
nginx_ingress_controller 98.36% <ø> (ø)
openldap 96.79% <ø> (ø)
postfix 88.04% <ø> (ø)
powerdns_recursor 96.65% <ø> (ø)
prometheus 94.17% <ø> (ø)
riak 99.22% <ø> (ø)
riakcs 93.61% <ø> (ø)
scylla 100.00% <ø> (ø)
squid 100.00% <ø> (ø)
ssh_check 91.58% <ø> (ø)
statsd 87.36% <ø> (+1.05%) ⬆️
supervisord 90.14% <ø> (ø)
system_core 92.66% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 92.92% <ø> (+1.34%) ⬆️
tls 92.18% <ø> (+0.82%) ⬆️
twemproxy 79.45% <ø> (ø)
twistlock 79.62% <ø> (ø)
windows_service 98.00% <ø> (ø)
wmi_check 92.91% <ø> (ø)
zk 82.62% <ø> (+1.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

julien-lebot
julien-lebot previously approved these changes Aug 17, 2023
View reviewed changes
@vivek-datadog
Copy link
Contributor Author

I lost track at this point, is this part of the pydantic v2 upgrade follow-ups? or is this a follow-up to the pre-release dep upgrade?

Could you link the relevant predecessor pr in the motivation?

Updated the motivation based on slack conversation

FlorentClarret
FlorentClarret previously approved these changes Aug 17, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Aug 17, 2023 •
edited
Loading

Test Results

   303 files     303 suites   1h 33m 6s ⏱️
   788 tests    769 ✔️   17 💤 2 ❌
2 132 runs  1 935 ✔️ 195 💤 2 ❌

For more details on these failures, see this check.

Results for commit 3ea9cff.

♻️ This comment has been updated with latest results.

davidor
davidor previously approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@davidor davidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for files owned by container-integrations 👍

@jhgilbert jhgilbert self-assigned this Aug 17, 2023
jhgilbert
jhgilbert previously approved these changes Aug 17, 2023
View reviewed changes
rtrieu
rtrieu previously approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vivek-datadog vivek-datadog dismissed stale reviews from rtrieu and jhgilbert via f43f16d August 18, 2023 05:28
@vivek-datadog vivek-datadog force-pushed the vivek-datadog/datadog-checks-base-version-update branch from f43f16d to 310041f Compare August 18, 2023 05:50
@vivek-datadog
Copy link
Contributor Author

vivek-datadog commented Aug 18, 2023 •
edited by jira bot
Loading

Gunicorn flakey test: AI-3290
Postgres flakey test: DBM-2732
Windows test failure (TCP on windows and Windows Service): Due to container unavailability. Seen in master as well though on py3

All the tests passed with an earlier version of the pr without changes to the relevant files confirming the failures are not due to base check version update

@vivek-datadog vivek-datadog merged commit 1e047eb into master Aug 18, 2023
@vivek-datadog vivek-datadog deleted the vivek-datadog/datadog-checks-base-version-update branch August 18, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentClarret FlorentClarret FlorentClarret approved these changes

@rtrieu rtrieu rtrieu left review comments

@jhgilbert jhgilbert jhgilbert left review comments

@davidor davidor davidor left review comments

@julien-lebot julien-lebot julien-lebot left review comments

@iliakur iliakur Awaiting requested review from iliakur

Assignees

@jhgilbert jhgilbert

Labels
documentation integration/ambari integration/apache integration/cassandra_nodetool integration/cassandra integration/ceph integration/cisco_aci integration/confluent_platform integration/consul integration/crio integration/datadog_cluster_agent integration/druid integration/foundationdb integration/glusterfs integration/go_expvar integration/gunicorn integration/harbor integration/hive integration/hivemq integration/hudi integration/hyperv integration/ignite integration/jboss_wildfly integration/kafka integration/kube_dns integration/kube_metrics_server integration/kube_proxy integration/kube_scheduler integration/kubelet integration/kyototycoon integration/lighttpd integration/linux_proc_extras integration/mapr integration/marathon integration/mesos_master integration/mesos_slave integration/nagios integration/nfsstat integration/nginx_ingress_controller integration/openldap integration/postfix integration/postgres integration/powerdns_recursor integration/presto integration/prometheus integration/riak integration/riakcs integration/scylla integration/solr integration/squid integration/ssh_check integration/statsd integration/supervisord integration/system_core integration/system_swap integration/tcp_check integration/tls integration/tomcat integration/twemproxy integration/twistlock integration/weblogic integration/windows_service integration/wmi_check integration/zk qa/skip-qa Automatically skip this PR for the next QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vivek-datadog @julien-lebot @iliakur @davidor @jhgilbert @FlorentClarret @rtrieu