Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the minimum datadog-checks-base version #15217

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Bump the minimum datadog-checks-base version #15217

merged 1 commit into from
Jul 12, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jul 10, 2023 •
edited
Loading

What does this PR do?

Bump the minimum datadog-checks-base version

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@FlorentClarret FlorentClarret requested review from a team as code owners July 10, 2023 08:51
@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited
Loading

Codecov Report

Merging #15217 (827061a) into master (411e4e4) will increase coverage by 0.23%.
The diff coverage is n/a.

Flag Coverage Δ
active_directory 100.00% <ø> (+17.64%) ⬆️
aspdotnet 100.00% <ø> (+26.19%) ⬆️
avi_vantage 92.54% <ø> (ø)
dotnetclr 91.39% <ø> (+12.90%) ⬆️
exchange_server 96.85% <ø> (+11.81%) ⬆️
ibm_ace 91.79% <ø> (ø)
iis 95.00% <ø> (+37.60%) ⬆️
impala 97.97% <ø> (ø)
teradata 94.24% <ø> (ø)
win32_event_log 86.40% <ø> (+0.27%) ⬆️
windows_performance_counters 98.36% <ø> (ø)
yarn 89.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

vivek-datadog
vivek-datadog approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@vivek-datadog vivek-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

Test Results

  29 files    29 suites   13m 47s ⏱️
199 tests 197 ✔️   2 💤 0 ❌
345 runs  292 ✔️ 53 💤 0 ❌

Results for commit 827061a.

@FlorentClarret FlorentClarret merged commit dc28258 into master Jul 12, 2023
@FlorentClarret FlorentClarret deleted the florentclarret/pydantic/bump_min_base_check_version branch July 12, 2023 15:01
iliakur pushed a commit that referenced this pull request Jul 13, 2023
@FlorentClarret @iliakur
Bump the minimum datadog-checks-base version (#15217)
8082349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivek-datadog vivek-datadog vivek-datadog approved these changes

@julien-lebot julien-lebot julien-lebot approved these changes

Assignees
No one assigned
Labels
integration/active_directory integration/aspdotnet integration/avi_vantage integration/dotnetclr integration/exchange_server integration/ibm_ace integration/iis integration/impala integration/teradata integration/win32_event_log integration/windows_performance_counters integration/yarn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FlorentClarret @julien-lebot @vivek-datadog