Allow disabling of replica access #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmuesch
reviewed
May 7, 2018
mongo/datadog_checks/mongo/mongo.py
Outdated
| self._report_replica_set_state( | ||
| data['state'], clean_server_name, replset_name, self.agentConfig | ||
| ) | ||
| if not instance.get('disable_replica_check'): |
There was a problem hiding this comment.
We may want to use the self._is_affirmative function here so we can handle the variations of Yes, yes, no, No, etc.
mongo/conf.yaml.example
Outdated
| # Whether or not to disable reads from available replicas. | ||
| # Use this if any replicas are inaccessible to the agent. | ||
| # | ||
| # disable_replica_check: false |
There was a problem hiding this comment.
Just a nit: Can we have this be an affirmative choice? Like enable_replica_check? Having it be an affirmative typically causes less confusion for people and may be more intuitive.
nmuesch
approved these changes
May 7, 2018
rishabh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This allow customers to disable replica access by PyMongo.
Motivation
Resolves DataDog/dd-agent#2522