Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert protobuf dependency update #14618

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented May 26, 2023

What does this PR do?

Revert protobuf dep to version prior to #14594

Motivation

Failing tests after merging to master which somehow the branch's CI missed.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@alopezz alopezz force-pushed the alopez/revert-protobuf-update branch from 18d2873 to f1d1e7b Compare May 26, 2023 08:15
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #14618 (f1d1e7b) into master (a2299e3) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
gitlab_runner 91.94% <ø> (ø)
kube_dns 95.97% <ø> (ø)
kubernetes_state 89.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@alopezz alopezz merged commit d5e2808 into master May 26, 2023
@alopezz alopezz deleted the alopez/revert-protobuf-update branch May 26, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants