-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OSD metadata tags #14201
Merged
Merged
Add OSD metadata tags #14201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
integration/ceph
label
Mar 21, 2023
at time of writing, objectstore is useful for tracking the status of the filestore and bluestore migration
associating OSD metrics with the device ID allows more individual tracking of disks device class is useful for tracking a migration between hard disks and solid state disks
Docs said to install python 3.8, but it looks like the tests are failing on f-strings in py 2.7.4? |
We only need to iterate through the metadata once
yzhan289
reviewed
Jun 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting
yzhan289
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Pull several values from osd metadata as tags. This separates metrics by device ID, class, objectstore, and ceph version
Motivation
We've been using these tags to track a couple of migrations in our ceph cluster, including hdd to ssd upgrades, filestore to bluestore, and version upgrades, as well as identifying problematic drives using device identifiers.
Additional Notes
This is based on my patch files, so I haven't yet gotten tests/integration into the repo cleanly. I haven't had luck getting a dev environment set up on my personal laptop in the past, so I'll need to give that another try
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.