-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract relation metrics for toast tables #14156
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hey @bonnefoa 👋 Just a heads up that we will freeze the repo on Friday for Agent 7.47. Let us know if you want to include this in the next release! |
I need to rework this PR, it won't be ready for the next freeze. Thanks for the headsup :) |
Hey @bonnefoa, very friendly reminder this PR is still pending. Let us know if you need a hand |
Closing this PR since it's still a draft, feel free to re-open it if needed 🙂 |
What does this PR do?
We currently only pull relation metrics from
pg_stat_user_tables
andpg_stat_user_indexes
. However, those tables don't include toast tables so we're missing metrics on toast tables.Motivation
Since data bigger than 2KB will be split in chunk of 2KB and moved in the toast table, an update of a table with toast data can generate hundred of tuple updates behind the hood that will not appear on the user table's stats.
We need to fetch them explicitly to get relations metrics like number of live rows/dead rows in the toast table and number of returned rows.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.