Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DBM-2204] mysql: set self._check instance variables to make tracking work #14146

Merged
merged 1 commit into from
Mar 13, 2023
Merged

[DBM-2204] mysql: set self._check instance variables to make tracking work #14146

merged 1 commit into from
Mar 13, 2023

Conversation

EmmaOnThursday
Copy link
Contributor

@EmmaOnThursday EmmaOnThursday commented Mar 13, 2023 •
edited
Loading

What does this PR do?

The tracked_method decorator is failing to track methods in two classes, MySQLStatementMetrics and MySQLStatementSamples, because the self._check variable is not available. This sets self._check on each
of those classes.

Motivation

Jira bug report
Related support ticket

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@EmmaOnThursday
mysql: set self._check instance variables to make tracking work
04e8349 
The tracked_method decorator is failing to track methods in
two classes, MySQLStatementMetrics and MySQLStatementSamples,
because the self._check variable is not available.
@EmmaOnThursday EmmaOnThursday requested review from a team as code owners March 13, 2023 17:39
@ghost ghost added the integration/mysql label Mar 13, 2023
@EmmaOnThursday EmmaOnThursday changed the title mysql: set self._check instance variables to make tracking work [DBM-2204] mysql: set self._check instance variables to make tracking work Mar 13, 2023
alexandre-normand
alexandre-normand approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@alexandre-normand alexandre-normand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #14146 (04e8349) into master (647e9d4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
mysql 87.67% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@EmmaOnThursday EmmaOnThursday merged commit cc41d32 into master Mar 13, 2023
@EmmaOnThursday EmmaOnThursday deleted the emma/fix-mysql-tracking branch March 13, 2023 18:31
github-actions bot pushed a commit that referenced this pull request Mar 13, 2023
@EmmaOnThursday
mysql: set self._check instance variables to make tracking work (#14146)
82d06fd 
The tracked_method decorator is currently failing to track methods in two classes, MySQLStatementMetrics and MySQLStatementSamples, because the self._check variable is not available. cc41d32
@asenci asenci mentioned this pull request Apr 19, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-normand alexandre-normand alexandre-normand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmmaOnThursday @alexandre-normand