Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing metrics #14088

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Add missing metrics #14088

merged 1 commit into from
Mar 2, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Mar 2, 2023 •
edited
Loading

What does this PR do?

Add missing metrics to the envoy integration.

Motivation

  • Support case.
  • I only added a couple of them and created a card in our backlog for the other ones as it seems we are missing more. AI-2943

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@ghost ghost added the integration/envoy label Mar 2, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023 •
edited
Loading

Codecov Report

Merging #14088 (377141e) into master (e1ea3a6) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
envoy 94.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret FlorentClarret marked this pull request as ready for review March 2, 2023 13:08
@FlorentClarret FlorentClarret requested a review from a team as a code owner March 2, 2023 13:08
@FlorentClarret FlorentClarret force-pushed the florentclarret/envoy/missing-metrics branch from c66f634 to 377141e Compare March 2, 2023 13:12
@FlorentClarret FlorentClarret mentioned this pull request Mar 2, 2023
Closed
4 tasks
@FlorentClarret FlorentClarret merged commit 2137bcd into master Mar 2, 2023
@FlorentClarret FlorentClarret deleted the florentclarret/envoy/missing-metrics branch March 2, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alopezz alopezz alopezz approved these changes

Assignees
No one assigned
Labels
integration/envoy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorentClarret @alopezz