Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch count method to monotonic count, that's correct for OM counts #13972

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Feb 15, 2023

What does this PR do?

This is a fix for a previous fix given that I learned the difference between count and monotonic_count methods 🙈

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@iliakur iliakur requested a review from a team as a code owner February 15, 2023 20:36
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #13972 (e310302) into master (6845bac) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Flag Coverage Δ
amazon_msk 89.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@yzhan289 yzhan289 merged commit b7a6f9c into master Feb 15, 2023
@yzhan289 yzhan289 deleted the ik/amazon_msk/switch-count-to-monotonic-count branch February 15, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants