Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document feature in journald user-level filtering #13701

Closed
wants to merge 2 commits into from
Closed

Document feature in journald user-level filtering #13701

wants to merge 2 commits into from

Conversation

ian28223
Copy link
Contributor

@ian28223 ian28223 commented Jan 16, 2023 •
edited
Loading

What does this PR do?

Document feature in introduced in #11398

Motivation

  • AGENT-7627
  • FRAGENT-1752

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@ian28223 ian28223 requested review from a team as code owners January 16, 2023 03:31
kayayarai
kayayarai requested changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@kayayarai kayayarai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edits. Not quite sure I kept your intent in the last Note -- please suggest an alternative wording if not. Maybe an example would clarify?

journald/README.md Outdated Show resolved Hide resolved
journald/README.md Outdated Show resolved Hide resolved
journald/README.md Outdated Show resolved Hide resolved
@ian28223 ian28223 closed this Jan 17, 2023
@ian28223 ian28223 mentioned this pull request Jan 17, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayayarai kayayarai kayayarai requested changes

Assignees
No one assigned
Labels
changelog/no-changelog documentation integration/journald
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian28223 @kayayarai