Update dependencies #13478
Merged
Update dependencies #13478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
The |
iliakur
force-pushed
the
ik/update-deps
branch
from
938fcf3 to
7be4d1a
Compare
|
The |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
yzhan289
reviewed
Dec 8, 2022
trishankatdatadog
previously approved these changes
Dec 8, 2022
iliakur
force-pushed
the
ik/update-deps
branch
from
37cb3bb to
0fff9e5
Compare
FlorentClarret
requested changes
Dec 9, 2022
Comment on lines
+43
to
+44
| "clickhouse-cityhash==1.0.2.3; python_version < '3.0'", | ||
| "clickhouse-cityhash==1.0.2.4; python_version > '3.0'", |
There was a problem hiding this comment.
I'm not sure why we do not have the same version for py2 and py3, 1.0.2.4 seems to support py2 https://github.com/xzkostyan/clickhouse-cityhash/blob/master/setup.py#L91. Any ideas?
There was a problem hiding this comment.
Since this is not a blocker and there's time pressure, ignoring it for now :(
alopezz
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Other than https://github.com/DataDog/integrations-core/pull/13478/files#r1044265181 and waiting for the agent build to succeed, I don't see anything else to worry about.
|
Thank you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attachedqa/skip-qalabel.