Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps base check requirement to v25.4.0 #12733

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Bumps base check requirement to v25.4.0 #12733

merged 1 commit into from
Aug 15, 2022

Conversation

fanny-jiang
Copy link
Contributor

@fanny-jiang fanny-jiang commented Aug 11, 2022 •
edited
Loading

What does this PR do?

Bumps base check requirement to v25.4.0

Motivation

Fix CI

New QueryExecutor class added in #12657:
https://github.com/DataDog/integrations-core/blob/master/datadog_checks_base/CHANGELOG.md#2540--2022-05-10

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@fanny-jiang fanny-jiang requested review from a team as code owners August 11, 2022 15:36
@ghost ghost added the integration/mysql label Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022 •
edited
Loading

Codecov Report

Merging #12733 (f96b569) into master (f29d304) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
mysql 87.97% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@fanny-jiang fanny-jiang merged commit c33c781 into master Aug 15, 2022
@fanny-jiang fanny-jiang deleted the fanny/mysql-deps branch August 15, 2022 19:46
steveny91 pushed a commit that referenced this pull request Aug 18, 2022
@fanny-jiang @steveny91
bump base check requirement to 25.4.0 (#12733)
855ac0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhan289 yzhan289 yzhan289 approved these changes

Assignees
No one assigned
Labels
integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fanny-jiang @yzhan289