Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra metrics description example #12043

Merged
merged 3 commits into from
May 18, 2022
Merged

Fix extra metrics description example #12043

merged 3 commits into from
May 18, 2022

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented May 17, 2022 •
edited
Loading

What does this PR do?

Fixes the example in the description of extra_metrics

Motivation

QA for #12012

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov
Copy link

codecov bot commented May 17, 2022 •
edited
Loading

Codecov Report

Merging #12043 (c16c7b9) into master (1c61098) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 78.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt changed the title Update extra metrics example description Fix extra metrics example description May 17, 2022
@ghost ghost added the integration/vault label May 17, 2022
@sarah-witt sarah-witt changed the title Fix extra metrics example description Fix extra metrics description example May 17, 2022
@sarah-witt sarah-witt marked this pull request as ready for review May 17, 2022 19:03
@sarah-witt sarah-witt requested review from a team as code owners May 17, 2022 19:03
cswatt
cswatt approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no docs review needed, approving so as not to block

fanny-jiang
fanny-jiang approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@fanny-jiang fanny-jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@sarah-witt sarah-witt added the category/bugfix For use during Agent Release period label May 18, 2022
@sarah-witt sarah-witt merged commit 33a3f37 into master May 18, 2022
@sarah-witt sarah-witt deleted the sarah/update-extra-metrics-example-description branch May 18, 2022 20:30
sarah-witt added a commit that referenced this pull request May 19, 2022
@sarah-witt
Fix extra metrics description example (#12043)
e2d1758 
* update extra_metrics docs

* Only do for extra metrics

* Sync config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanny-jiang fanny-jiang fanny-jiang approved these changes

@cswatt cswatt cswatt approved these changes

Assignees
No one assigned
Labels
category/bugfix For use during Agent Release period dev/tooling integration/aerospike integration/amazon_msk integration/arangodb integration/avi_vantage integration/calico integration/cilium integration/cockroachdb integration/coredns integration/datadog_checks_dev integration/envoy integration/haproxy integration/istio integration/kong integration/linkerd integration/openmetrics integration/pulsar integration/vault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarah-witt @cswatt @fanny-jiang