-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Envoy] Support envoy.cluster.outlier_detection.*
in OpenMetrics V2
#11860
Merged
FlorentClarret
merged 8 commits into
master
from
keisku/add_outlier_detection_to_openmetrics
Aug 19, 2022
Merged
[Envoy] Support envoy.cluster.outlier_detection.*
in OpenMetrics V2
#11860
FlorentClarret
merged 8 commits into
master
from
keisku/add_outlier_detection_to_openmetrics
Aug 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envoy.cluster.outlier_detection.*
in OpenMetrics V2envoy.cluster.outlier_detection.*
in OpenMetrics V2
keisku
commented
Apr 20, 2022
Where can I add test values for I want to fix this CI error.
|
fanny-jiang
reviewed
May 11, 2022
22e876d
to
cfedf7b
Compare
fanny-jiang
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support
envoy.cluster.outlier_detection.*
in OpenMetrics V2, /stats/prometheus.Motivation
Agent doesn't collect
envoy.cluster.outlier_detection.*
for now even Agent used to collect those metrics from the /stats. If my understanding is correct, this behavior changed is from #10752Example log message that shows Agent ignore
envoy.cluster.outlier_detection.*
in OpenMetrics V2.Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached