Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix activity host reporting #11854

Merged
merged 9 commits into from
Apr 20, 2022
Merged

Fix activity host reporting #11854

merged 9 commits into from
Apr 20, 2022

Conversation

alexbarksdale
Copy link
Member

@alexbarksdale alexbarksdale commented Apr 18, 2022 •
edited
Loading

What does this PR do?

Fixes the host reported on the activity payloads for MySQL.

Motivation

If a user configures the integration's reported_hostname option, the activity payload will not contain the configured hostname.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@alexbarksdale alexbarksdale marked this pull request as ready for review April 18, 2022 20:59
@alexbarksdale alexbarksdale requested review from a team as code owners April 18, 2022 20:59
@codecov
Copy link

codecov bot commented Apr 19, 2022 •
edited
Loading

Codecov Report

Merging #11854 (9bffb33) into master (8386537) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Flag Coverage Δ
mysql 88.68% <100.00%> (+1.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

djova
djova requested changes Apr 19, 2022
View reviewed changes
mysql/datadog_checks/mysql/activity.py Outdated Show resolved Hide resolved
djova
djova requested changes Apr 19, 2022
View reviewed changes
mysql/tests/test_statements.py Outdated Show resolved Hide resolved
@alexbarksdale alexbarksdale requested a review from djova April 19, 2022 23:25
djova
djova requested changes Apr 20, 2022
View reviewed changes
mysql/tests/test_query_activity.py Outdated Show resolved Hide resolved
@alexbarksdale alexbarksdale requested a review from djova April 20, 2022 14:21
@alexbarksdale alexbarksdale merged commit 68f11ec into master Apr 20, 2022
@alexbarksdale alexbarksdale deleted the alex.barksdale/fix-mysql-activity-reported-hostname branch April 20, 2022 16:57
steveny91 pushed a commit that referenced this pull request Apr 20, 2022
@alexbarksdale @steveny91
mysql: Fix activity host reporting (#11854)
745a3bb 
* Fix activity host reporting

* Fix config_host value

* Fix linting

* Reduce flakiness

* Fix incorrect query signature

* Fix flakiness

* Address feedback

* fix linting

* Cleanup
@steveny91 steveny91 changed the title mysql: Fix activity host reporting Fix activity host reporting Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djova djova djova approved these changes

Assignees
No one assigned
Labels
category/bugfix For use during Agent Release period integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexbarksdale @djova