Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support newer versions of click #11746

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Support newer versions of click #11746

merged 3 commits into from
Mar 29, 2022

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Mar 29, 2022 •
edited
Loading

@ofek ofek requested a review from a team as a code owner March 29, 2022 01:29
@codecov
Copy link

codecov bot commented Mar 29, 2022 •
edited
Loading

Codecov Report

Merging #11746 (d36f5e6) into master (d4db50a) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Flag Coverage Δ
ambari 85.75% <ø> (ø)
calico 83.33% <ø> (ø)
cilium 75.34% <ø> (+0.93%) ⬆️
cloud_foundry_api 95.98% <ø> (+0.12%) ⬆️
crio 89.79% <ø> (ø)
datadog_cluster_agent 90.00% <ø> (ø)
disk 89.42% <ø> (ø)
hazelcast 92.39% <ø> (ø)
istio 77.46% <ø> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ofek ofek requested review from a team as code owners March 29, 2022 02:06
steveny91
steveny91 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@steveny91 steveny91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ofek ofek merged commit 275c0c2 into master Mar 29, 2022
@ofek ofek deleted the ofek/d branch March 29, 2022 02:39
github-actions bot pushed a commit that referenced this pull request Mar 29, 2022
@ofek
Support newer versions of click (#11746)
533ce4a 
* Support newer versions of `click`

* .

* style 275c0c2
@mgarabed mgarabed mentioned this pull request Mar 29, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveny91 steveny91 steveny91 approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/aerospike integration/datadog_checks_base integration/datadog_checks_dev integration/disk integration/ecs_fargate integration/kubelet integration/mongo integration/network integration/php_fpm integration/snmp integration/tls integration/tokumx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofek @steveny91