Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example config #11515

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Update example config #11515

merged 2 commits into from
Feb 16, 2022

Conversation

celenechang
Copy link
Contributor

What does this PR do?

  • Add spec.yaml files for kubernetes_state and kubelet checks
  • Update conf files accordingly

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #11515 (4cdaa0e) into master (7c3e92d) will increase coverage by 0.01%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 79.21% <ø> (ø)
druid 97.70% <ø> (ø)
kubelet 90.46% <ø> (+0.83%) ⬆️
kubernetes_state 89.54% <ø> (ø)
spark 93.56% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@celenechang celenechang force-pushed the celene/add_missing_kube_specs branch from b5e213d to 889fe32 Compare February 16, 2022 16:57
clamoriniere
clamoriniere previously approved these changes Feb 16, 2022
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

kubelet/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
kubelet/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
kubelet/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
kubelet/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
kubelet/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
kubernetes_state/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
kubernetes_state/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
kubernetes_state/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
kubernetes_state/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
@ofek ofek changed the title [kubelet/kubernetes_state] add spec.yaml files Update example config Feb 16, 2022
@ofek ofek merged commit bf7b85a into master Feb 16, 2022
@ofek ofek deleted the celene/add_missing_kube_specs branch February 16, 2022 21:04
github-actions bot pushed a commit that referenced this pull request Feb 16, 2022
* [kubelet/kubernetes_state] add spec.yaml files

* updates from review bf7b85a
@fdc-liebreich
Copy link

I think, you unintentionally removed join_standard_tags from kubernetes_state/data/conf.yaml.example, referenced in the documentation.

@celenechang
Copy link
Contributor Author

@fdc-liebreich sorry about that, thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants