Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling querying an exporter #11306

Merged
merged 3 commits into from
Feb 18, 2022
Merged

Conversation

ian28223
Copy link
Contributor

@ian28223 ian28223 commented Feb 7, 2022

What does this PR do?

Allows to disable querying an exporter by setting the port to 0

Motivation

  • AGENT-7470

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

maycmlee
maycmlee previously approved these changes Feb 7, 2022
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs.

Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you write a test for when each of these are disabled?

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #11306 (d2b1d4c) into master (32a4d58) will decrease coverage by 0.44%.
The diff coverage is 87.27%.

Flag Coverage Δ
active_directory ?
activemq_xml ?
aerospike ?
airflow ?
amazon_msk 88.67% <87.27%> (-0.17%) ⬇️
ambari ?
apache ?
aspdotnet ?
avi_vantage ?
azure_iot_edge ?
btrfs ?
cacti ?
cassandra_nodetool ?
ceph ?
cilium ?
cisco_aci ?
citrix_hypervisor ?
clickhouse ?
cloud_foundry_api ?
cockroachdb ?
consul ?
coredns ?
couch ?
couchbase ?
crio ?
datadog_checks_base ?
datadog_checks_dev ?
datadog_checks_downloader ?
datadog_cluster_agent ?
directory ?
disk ?
dns_check ?
dotnetclr ?
druid ?
ecs_fargate ?
eks_fargate ?
elastic ?
envoy ?
etcd ?
exchange_server ?
external_dns ?
fluentd ?
gearmand ?
gitlab ?
gitlab_runner ?
glusterfs ?
go_expvar ?
gunicorn ?
haproxy ?
harbor ?
hazelcast ?
hdfs_datanode ?
hdfs_namenode ?
http_check ?
ibm_db2 ?
ibm_i ?
ibm_mq ?
ibm_was ?
iis ?
istio ?
kafka_consumer ?
kong ?
kube_apiserver_metrics ?
kube_controller_manager ?
kube_dns ?
kube_metrics_server ?
kube_proxy ?
kube_scheduler ?
kubelet ?
kubernetes_state ?
kyototycoon ?
lighttpd ?
linkerd ?
linux_proc_extras ?
mapr ?
mapreduce ?
marathon ?
marklogic ?
mcache ?
mesos_master ?
mesos_slave ?
mongo ?
mysql ?
nagios ?
network ?
nfsstat ?
nginx ?
nginx_ingress_controller ?
openldap ?
openmetrics ?
openstack ?
openstack_controller ?
oracle ?
pdh_check ?
pgbouncer ?
php_fpm ?
postfix ?
postgres ?
powerdns_recursor ?
process ?
prometheus ?
proxysql ?
rabbitmq ?
redisdb ?
rethinkdb ?
riak ?
riakcs ?
sap_hana ?
scylla ?
singlestore ?
snmp ?
snowflake ?
sonarqube ?
spark ?
sqlserver ?
squid ?
ssh_check ?
statsd ?
supervisord ?
system_core ?
system_swap ?
tcp_check ?
teamcity ?
tls ?
twemproxy ?
twistlock ?
varnish ?
vault ?
vertica ?
voltdb ?
vsphere ?
win32_event_log ?
windows_performance_counters ?
windows_service ?
wmi_check ?
yarn ?
zk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@ian28223 ian28223 force-pushed the ian.bucad/amazon_msk_disable branch from 7951f27 to fcb908d Compare February 17, 2022 23:49
sarah-witt
sarah-witt previously approved these changes Feb 18, 2022
@sarah-witt sarah-witt changed the title Allows to disable querying an exporter Allow disabling querying an exporter Feb 18, 2022
@sarah-witt sarah-witt merged commit 58bc121 into master Feb 18, 2022
@sarah-witt sarah-witt deleted the ian.bucad/amazon_msk_disable branch February 18, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants